add options.attachStacktrace #160
Conversation
|
missing this: this assignment should only be made if attachStacktrace is also enabled |
- serialize event.stracktrace within a threads interface
✅ |
| @@ -73,6 +77,7 @@ class Hub { | |||
| try { | |||
| sentryId = await item.client.captureEvent( | |||
| event, | |||
| stackTrace: stackTrace, | |||
There was a problem hiding this comment.
What about we make the stackTrace part of the hint?
The idea of hint was to have a single .. hint to deal with these extra things without having to expand the public API
There was a problem hiding this comment.
the hint still could be used for other stuff as we do on Android, but stackTrace on dart is captured separately so it makes sense IMO to have this expanded API.
on Java, a stack trace is always part of the exception, which is not this case.
The other way would be adding a new field (that is also called stackTrace or sentryStackTrace) to the event, which is confusing.
📢 Type of change
📜 Description
SentryOptions.attachStackTraceto attach stacktrace on captureMessage and captureEvent ( true by default )💡 Motivation and Context
https://develop.sentry.dev/sdk/unified-api/
💚 How did you test it?
new tests to verify if stacktrace is correctly sended
📝 Checklist
🔮 Next steps